Our paper decomposes knowledge-diffusing trade flows and estimates their impacts separately. Overall, trade generates positive knowledge spillovers, but the effects of intra-industry trade are ambiguous. With regard to sectoral import penetration, we find that potential positive spillovers are...